-
Notifications
You must be signed in to change notification settings - Fork 103
Download language list #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download language list #578
Conversation
…re cell configuration
Thank you for the pull request! 💙The Scribe-iOS team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
hi @andrewtavis, this is still work in progress, but open for review when you have the time :) |
|
So far the menu navigation and all else is functioning quite well, @catreedle! Please let us know if you have questions or need support 😊 |
sure!
Ideally, pressing back should take the user directly to the Installation screen (let me know if I'm wrong about this). I plan to investigate this further, but any guidance or support would be appreciated. 😊 |
|
hi @andrewtavis, I have a question about the expected behavior when the app is backgrounded and reopened. |
* Fix tab bar appearance on iOS < 26 * Fix tab bar appearance on iOS < 26 and adapt colors for light/dark mode * Minor comment edits --------- Co-authored-by: Andrew Tavis McAllister <[email protected]>
* Updated scri.be website link in About tab * Minor update to re-run CI * Remove unrelated AppDelegate changes from this PR * Switch icon over to a globe and change text to visit website --------- Co-authored-by: Andrew Tavis McAllister <[email protected]>
|
Hey @catreedle 👋 Answering your question above here in the sync for documentation :) I do agree that we would always want the back button of the download data page to go to the installation page. If we can figure this out, then that would be ideal :) |
|
Looks good to me |
andrewtavis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: All's working very well here, @catreedle! Really is amazing to see the UI fully finished 🤩 Looking forward to adding in the functionality to it!
Contributor checklist
xcodebuildandswiftlint --strictcommands as directed in the testing section of the contributing guideDescription
This PR implements the download language selection and confirmation flow for the Download Data screen.
Changes:
parentSectionto cells before configuration (WrapperCell.swift and TableViewTemplateViewController.swift)Related issue